Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimble for nim1.0 #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Nimble for nim1.0 #3

wants to merge 4 commits into from

Conversation

cerk
Copy link

@cerk cerk commented Oct 5, 2019

Just to warn you, I'm a new nim user and don't often use git. I installed nim 1.0 recently and tried to nimble install your decimal package and it didn't seem to work. I reorganized this repo based on the nimble documentation here: https://github.com/nim-lang/nimble#creating-packages

Now it works for me if I do:
nimble install https://github.com/cerk/nim-decimal@#nimbleForNim1.0

I'm assuming there were breaking changes to nimble at some point when nim 1.0 arrived. Either that, or it's possible I am just missing something obvious.

@mratsim
Copy link
Contributor

mratsim commented Mar 19, 2020

Oops I didn't see this pull request.

Very sorry.
I can't reproduce on my side, the installation works fine for me.

Regarding naming, using src creates issues down the line because on installation Nimble strips the src and that breaks imports (nim-lang/nimble#653)

However Nimble had a couple of installation bugs this past summer:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants